Windows 11: simplerecorder error

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
79 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
Hard battle!

So, to resume, with /uos/lib LibPortaudio-64.dll running deviceinfos.exe with debugger it crash at loading?
Or it crash at close?
And it shows 2 chans for input.

But with new compiled LibPortaudio dll, v19.7, even with debugger, it does not crash, nor at loading, nor at closing?
And it shows 1 chan for input.

Is it ok now, with  /uos/lib LibPortaudio-64.dll  and without debugging to save to wav/ogg, into mono or stereo file?
Is it ok now, with new compiled LibPortaudio dll, v19.7  and with or without debugging to save to wav/ogg, into mono or stereo file?
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

NeedUOS
> running deviceinfos.exe with debugger it crash at loading?
After pushing button 'Load libraries' it calls uos_GetInfoDevice and then uos_UpdateDevice.

procedure uos_UpdateDevice();
begin
  Pa_Terminate(); // here the crash happens
  Pa_Initialize();
end;

> nor at loading, nor at closing? And it shows 1 chan for input?
Yes, yes, yes.

> with  /uos/lib LibPortaudio-64.dll  and without debugging
This saves into stereo file, because of wrongly detected 2 channels for microphone.

> with new compiled LibPortaudio dll, v19.7
This saves into mono file, because of correctly detected 1 channel for microphone.

-------------

Did you see the new uos.pas, which saves the wav file correctly?
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
> with  /uos/lib LibPortaudio-64.dll  and without debugging
This saves into stereo file, because of wrongly detected 2 channels for microphone.

The question was, in Simple Recorder:

 if CheckBox2.Checked then
      uos_AddIntoFile(PlayerIndex1, PChar(edit3.Text), -1, 1, -1, 4096, outformat);

Does it give a valid mono wav/ogg file?

And with this:

 if CheckBox2.Checked then
      uos_AddIntoFile(PlayerIndex1, PChar(edit3.Text), -1, 2, -1, 4096, outformat);

Does it give a valid stereo wav/ogg file?

The same question with last portaudio lib.

>Did you see the new uos.pas, which saves the wav file correctly?
I prefer that you show what you have changed.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

NeedUOS
Understand, I had to get rid of numchan in line 266.

> Does it give a valid mono wav/ogg file?
The resulting wav file is mono. But when opening in a wave editor:

This is not happening with my changes to uos.pas, which I show you later.

The ogg file: opening in a wave editor is ok. It is mono, but plays with half the speed both in simplerecorder and wave editor.

> Does it give a valid stereo wav/ogg file?
The resulting wav file is stereo. File is not valid like above.
The ogg file is ok in all aspects.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
This post was updated on .
Does you have a Github account?
It would be much easier for commit/pull request.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
>This is not happening with my changes to uos.pas, which I show you later.

Please use the last commit of uos when you do change.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

NeedUOS
In reply to this post by NeedUOS

Changes to uos.pas

Tuos_WaveHeaderChunk changed

Deleted wcbSize, it's not part of the wave header.

Changed size reflects in procedure WriteWave

  Data.data.Position := 40;         // since SizeOf(Header) is not 18 rather 16, so 42 - 2
  //(after 'data')
  wDataSize := Data.data.Size - 44; // 44 is the start of data

and other changes, but now I see:
What? Github? Yes. But how to make a commit?
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

NeedUOS
Yes, I used the last uos.pas from two days ago.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
In reply to this post by NeedUOS
>Deleted wcbSize, it's not part of the wave header.

Ha, ok, (but in the past, imho, it was) thanks.

>What? Github? Yes. But how to make a commit?
First do a fork of uos in your Github account, for this go to uos github:

https://github.com/fredvs/uos

And click on "fork".

Then go to your github account to see if the fork was done.
After this, depend if git is installed on your system.
If no, I think you can edit in site github-your-fork-of-uos, do change, save it and after click on "Pull Request".

But better to use git ( it is via terminal ) but also more tricky.
If you prefer use git or not possible to edit via github site, I will explain how to do.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

NeedUOS
Ok, done. I don't have git.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
OK, perfect, I see the pull request.

I have to leave now but will try on Linux/BSD and study deeply your pull-request later.
Many thanks for your contribution.

Write you later.

Fre;D
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

NeedUOS
Until next time
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
In reply to this post by fredvs
Hello Anjemor.

Your pull-request was merged:
https://github.com/fredvs/uos/commit/1feabefc4d6acfa4728e6a39008247ee9d290fe8

Many thanks!

I did a commit after because a copy of /uos/examples/uos.pas is also in /uos/src/uos.pas.

It would be great if you could test if all ok with those commits.
Here on Linux/BSD, no cry.

Maybe you could also give your binary of portaudio.
For this, the most easy is in your github site, create a new issue and add the zip file in the issue.

And the best, if possible, test that new portaudio binary on older Windows OS so I can give it in uos/lib alone or give it as second library (and then with other name)

Have fun.

Fre;D
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
This post was updated on .
Ooops, there is still something wrong here in unix.
Recording a stereo input into a mono ogg file.
OK, back in the jungle.

[EDIT] Fixed in last commit.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
> Does it give a valid mono wav/ogg file?
>The ogg file: opening in a wave editor is ok. It is mono, but plays with half the speed both in simplerecorder and wave editor.

I just tested on a Windows 11 machine that recognize the input as mono and the speed of the saved mono file in the simplerecorder player is ok.

 
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

NeedUOS
> give your binary of portaudio
Ok, done.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

NeedUOS
In reply to this post by fredvs
> that recognize the input as mono

Like I said: my input is recognized as stereo with old portaudio dll. When simplerecorder uses this line:

  uos_AddIntoFile(PlayerIndex1, PChar(edit3.Text), -1, 1, -1, 4096, outformat);

then half speed is the result in ogg file. I think that's ok, because of the channel mismatch.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

fredvs
Administrator
> that recognize the input as mono

> Like I said: my input is recognized as stereo with old portaudio dll. When simplerecorder uses this line:

Yes, it is the same for me, i was talking about the new portaudio.dll and here on the Windows 11, saved as mono, the speed is ok.
I did not try anymore with the old portaudio.dll.

But maybe I miss something, if so, i apologize.
Reply | Threaded
Open this post in threaded view
|

Re: Windows 11: simplerecorder error

NeedUOS
> I did not try anymore with the old portaudio.dll.


Then the issue is closed!

Thanks so much for still supporting your library! You earned some beer - when you come to Berlin!
1234